https://gitlab.synchro.net/main/sbbs/-/commit/d60cc9637f418ab7aa897945
Modified Files:
src/conio/x_events.c
Log Message:
Remove stale code from net_wm_state_is_cb()

It's unlikely this is what Digitalman reported from ASan and UBSan

---
� Synchronet � Vertrauen � Home of Synchronet � [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/0a6fdb956890d029bfdb230f
Modified Files:
src/conio/x_events.c
Log Message:
Fix crash in net_wm_state_is_cb when running GCC ASan-enabled build

Check size of X11 property before dereferencing as an Atom.
This fixes:
==10203==ERROR: AddressSanitizer: heap-buffer-overflow on address 0x602000065970 at pc 0x5c5834fb8812 bp 0x7819c717c220 sp 0x7819c717c218
READ of size 8 at 0x602000065970 thread T2 (X11 Events)
#0 0x5c5834fb8811 in net_wm_state_is_cb ../conio/x_events.c:1541

But I'm not clear when nitems_return (nir) might represent > 8-bit items or how to detect that, so perhaps there's a *better* fix?

---
� Synchronet � Vertrauen � Home of Synchronet � [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/e32a036b1b615aa2c07cbefc
Modified Files:
src/conio/x_events.c
Log Message:
Revert "Fix crash in net_wm_state_is_cb when running GCC ASan-enabled build"

This reverts commit 0a6fdb956890d029bfdb230f3fec17110690a471.

This simply caused the callback to never be called.

---
� Synchronet � Vertrauen � Home of Synchronet � [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/60668a729f1fdb570284a70c
Modified Files:
src/conio/x_events.c
Log Message:
Ensure we get at least one item before passing to the callback

Should fix ASan "crash".

---
� Synchronet � Vertrauen � Home of Synchronet � [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/f2d5534ae72cd7994e25ec77
Modified Files:
src/conio/x_events.c
Log Message:
Fix CTRL + CAPS issue in X11

Previously, both the shift key, and the "implied shift" from CAPS
were treated as a higher priority than the CTRL modifier. With
this change, only the explicit shift key has priority, and the
implicit one is only checked after CTRL is checked.

Fixes SourceForge bug 117

---
� Synchronet � Vertrauen � Home of Synchronet � [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/bc3d9e44b16a9a6d06cbb909
Modified Files:
src/conio/x_events.c
Log Message:
Move call to bitmap_drv_free_rect() out of vstatlock

---
� Synchronet � Vertrauen � Home of Synchronet � [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/bb9b789ca8fc185fcdfda32d
Modified Files:
src/conio/x_events.c
Log Message:
Bow to GCC harder.

---
� Synchronet � Vertrauen � Home of Synchronet � [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/57283c51fac9860dd350e639
Modified Files:
src/conio/x_events.c
Log Message:
Fix pasting in X11 mode... pastebuf should be UTF-8, not ISO-Latin1.

---
� Synchronet � Vertrauen � Home of Synchronet � [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/b9c51d8b9f5aab7f368c5c76
Modified Files:
src/conio/x_events.c
Log Message:
Fix warning.

---
� Synchronet � Vertrauen � Home of Synchronet � [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/36d37a5184d5263f8d1de3f4
Modified Files:
src/conio/x_events.c
Log Message:
Move saved_scaling inside vstatlock.

This shouldn't be necessary, but Coverity thinks it's a good idea,
and it's simple enough to do without hurting anything.

---
� Synchronet � Vertrauen � Home of Synchronet � [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/904d202aa2b0c906cf5ef25b
Modified Files:
src/conio/x_events.c
Log Message:
Call map_window() to update size hints when resizing the window.

This way, WMs that enforce aspect ratio etc, won't get potentially
block the update.

---
� Synchronet � Vertrauen � Home of Synchronet � [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/375bdb7806d6ef2996a6a7b7
Modified Files:
src/conio/x_events.c
Log Message:
Use max when we have it, only restore size/scaling in fullscreen mode

---
� Synchronet � Vertrauen � Home of Synchronet � [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/f616a09a6bf5bdd88e247850
Modified Files:
src/conio/x_events.c
Log Message:
First attempt to fix "black bars" startup issue.

The first time we receive a MapNotify or ConfigureNotify that sets
the width and height, resize the window instead of accepting the
current window size.

---
� Synchronet � Vertrauen � Home of Synchronet � [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/129dd7db9d00fe4be9f9b93a
Modified Files:
src/conio/x_events.c
Log Message:
Only count it as the "first resize" if it's not from SendEvent()

---
� Synchronet � Vertrauen � Home of Synchronet � [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/bd1c91e6bf0a98cb6f3ef43c
Modified Files:
src/conio/x_events.c
Log Message:
Always base scaling on size, and alwayse resize xim.

Fixes issue with possible corrupt display when "weird" scaling
changes occured.

---
� Synchronet � Vertrauen � Home of Synchronet � [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/37c79a65585b06197c219697
Modified Files:
src/conio/x_events.c
Log Message:
Count flushes to disable resize hack.

Instead of strictly using "first resize", also count flushes and
assume the hack isn't needed after five. Experimentation on my
ChromeBook shows 3 to be sufficient, so I'm sing five for now.

Odds are that this will still mess with tiling WMs, but I don't use
one, so I don't mind yet. I expect this will be better, but likely
still not great.

---
� Synchronet � Vertrauen � Home of Synchronet � [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/a130c61289d7bc2217d61665
Modified Files:
src/conio/x_events.c
Log Message:
Lower flush count to 3.

This is my happy place on the desktop system running xfce4... any
higher, and it interferes with how I manage my windows.

Hopefully, this value convers the initialization portion perfectly
on all systems (hah!).

---
� Synchronet � Vertrauen � Home of Synchronet � [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/fd0b6150ce3fb8c64b9ec0e3
Modified Files:
src/conio/x_events.c
Log Message:
Fix some weirdness around window sizing.

This should fix the recent issue when a larger or smaller version
is painted inside the window after resize, as well as fix ALT-
when the current size is not an integer multiple.

---
� Synchronet � Vertrauen � Home of Synchronet � [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/f5160b014413cbfee9c8ec7c
Modified Files:
src/conio/x_events.c
Log Message:
Fix build when XRandR is available, but Xinerama isn't.

---
� Synchronet � Vertrauen � Home of Synchronet � [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/f2257585720b4972280f48da
Modified Files:
src/conio/x_events.c
Log Message:
Actually don't call XSetICFocus() at start. :(

---
� Synchronet � Vertrauen � Home of Synchronet � [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/235ce71a6a01a20d6b3801a5
Modified Files:
src/conio/x_events.c
Log Message:
Never call XMapWindow() in response to a _NET_FRAME_EXTENTS change

This breaks at least herbstluftwm's focus-follows-mouse, and rustles
Cyan's jimmies.

It's also a terrible idea.

---
� Synchronet � Vertrauen � Home of Synchronet � [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/56c269ffc22dde02df5df429
Modified Files:
src/conio/x_events.c
Log Message:
If we're not mapping, only XSetWMNormalHints() if it's different.

---
� Synchronet � Vertrauen � Home of Synchronet � [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/d58c1bba6f02c14d23fe06c9
Modified Files:
src/conio/x_events.c
Log Message:
Refine last commit...

Add a comment explaining why we do what we do, and verify the aspect
is unchanged as well since we could change only the aspect and need
to set new hints in some cases.

---
� Synchronet � Vertrauen � Home of Synchronet � [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/ea0e1c4999f98b8804ece464
Modified Files:
src/conio/x_events.c
Log Message:
Fix warnings in last commit.

---
� Synchronet � Vertrauen � Home of Synchronet � [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/63434549e82588a0cac2404a
Modified Files:
src/conio/x_events.c
Log Message:
Fix some more warnings when not using optional features.

---
� Synchronet � Vertrauen � Home of Synchronet � [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/5e5ddd25ca0f8aeb6f3c71b4
Modified Files:
src/conio/x_events.c
Log Message:
Ensure max width and height are initialized

Prevents X11 mode from doing very weird things when we are unable
to get the max window size from the window manager.
Found by scan-build

---
� Synchronet � Vertrauen � Home of Synchronet � [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/d5a2666a0d78fa1d931758f0
Modified Files:
src/conio/x_events.c
Log Message:
Ensure max width and height are initialized for new window size

Prevents randomly sized windows in X11 mode when the max window
size can't be read from window manager.
Found by scan-build

---
� Synchronet � Vertrauen � Home of Synchronet � [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/86d5357334b6905759460aa8
Modified Files:
src/conio/x_events.c
Log Message:
As the final fallback for screen dimensions, use the root size.

---
� Synchronet � Vertrauen � Home of Synchronet � [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/015c976e20a466bfe798ea46
Modified Files:
src/conio/x_events.c
Log Message:
Allow fullscreen_geometry() before window is created

---
� Synchronet � Vertrauen � Home of Synchronet � [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/1a0b897182a9e874a6f78570
Modified Files:
src/conio/x_events.c
Log Message:
Add closing brace left out in previous commit.

---
� Synchronet � Vertrauen � Home of Synchronet � [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/44a8f52425c03c6ad6bb2456
Modified Files:
src/conio/x_events.c
Log Message:
Handle case where we receive a MapNotify without a ConfigureNotify first

This shouldn't happen, but it does!

---
� Synchronet � Vertrauen � Home of Synchronet � [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/fa05a42f5a35eb12fe5b57da
Modified Files:
src/conio/x_events.c
Log Message:
Fix initial setting of _NET_WM_ICON

Previously, did not include the size, so was a 0x0 icon.

---
� Synchronet � Vertrauen � Home of Synchronet � [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/8ead23f14344771b5a432e29
Modified Files:
src/conio/x_events.c
Log Message:
Ugh. Atom is unsigned long... unsigned long can be 64-bit

We can't just memcpy() this because it's not a uint32_t, it's an
Atom.

---
� Synchronet � Vertrauen � Home of Synchronet � [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/c9fdbfa213c2dbd16acddc02
Modified Files:
src/conio/x_events.c
Log Message:
Actually, it's a long, not an Atom... same thing though.

---
� Synchronet � Vertrauen � Home of Synchronet � [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/13fcf2f23a9d845ba5685258
Modified Files:
src/conio/x_events.c
Log Message:
Recalculate scaling when resize_window() is called in fullscreen mode.

---
� Synchronet � Vertrauen � Home of Synchronet � [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/baf9603eaa287c0f6e1ad5ce
Modified Files:
src/conio/x_events.c
Log Message:
Add some debug logging

Maybe we can figure out what the Chromebook is doing...

---
� Synchronet � Vertrauen � Home of Synchronet � [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/f300a32ef58f0340ce60f075
Modified Files:
src/conio/x_events.c
Log Message:
Remove debug code

It looks like the ChromeOS WM is resizeing the window. :(

---
� Synchronet � Vertrauen � Home of Synchronet � [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/819c6891d47851c2a49fff0f
Modified Files:
src/conio/x_events.c
Log Message:
Formatting

---
� Synchronet � Vertrauen � Home of Synchronet � [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/83c7914b3b10a49fba70ad08
Modified Files:
src/conio/x_events.c
Log Message:
Fix some scancodes...

It seems some of the Shift+x codes were incorrect (had unshifted
as high byte and shifted as low byte).

---
� Synchronet � Vertrauen � Home of Synchronet � [vert/cvs/bbs].synchro.net