https://gitlab.synchro.net/main/sbbs/-/commit/89637f0d043c012741932076
Modified Files:
src/sbbs3/ctrl/MainFormUnit.cpp
Log Message:
Display horizontal splitter in the correct spot.

For who knows how long now, the horizontal splitter that allows the sysop
to control the size of the top 2 panels (server forms), was displayed above
the top panel, not between the top and bottom panel, thus making the panel heights not controllable. Weird. Change the order of making the controls visible to insure that the splitter is displayed below the top panel and
on top of the bottom panel.

Also (non-functional changes):
Remove redunant mutex from client_on() - makes no difference.
Use try/catch in client_on() to try to catch VCL exceptions - doesn't catch
the "invalid index" error popups that we see on occasion. <shrug>

---
� Synchronet � Vertrauen � Home of Synchronet � [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/f4a2249b0d0c49dcdbc6ea06
Modified Files:
src/sbbs3/ctrl/MainFormUnit.cpp
Log Message:
Don't update displayed stats values if getstats() returns false (failure)

Use byte_estimate_to_str() to display upload/download byte totals (better support for totals in gibibytes, tebibytes, etc.).

---
� Synchronet � Vertrauen � Home of Synchronet � [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/bf1a2d4c3d34f3fda712bada
Modified Files:
src/sbbs3/ctrl/MainFormUnit.cpp
Log Message:
Remove the -l25 from the default SCFG command-line

... since that puts us back into VGA tall-font mode

---
� Synchronet � Vertrauen � Home of Synchronet � [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/57d4c080e28191752cb2ed0b
Modified Files:
src/sbbs3/ctrl/MainFormUnit.cpp
Log Message:
Fix the removal of "main.ini" filename from CtrlDir path, if supplied

Converting the path to UPPER case and then comparing against a lowercase
string would never work.

Bug introduced in commit 6edc027042d7, reported by xbit (XBITBBS)

---
� Synchronet � Vertrauen � Home of Synchronet � [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/a2cd1d341bc92ee3556a8694
Modified Files:
src/sbbs3/ctrl/MainFormUnit.cpp
Log Message:
Wrap all ClientForm->ListView->Items accesses in try/catch

... this appears to resolve the "invalid index" exceptions that could get thrown and pop-up error dialogs in SBBSCTRL-Win32 ... finally.

It's a mystery how the ListMutex isn't successfully protecting the ListView (the ListView->Items->Count becomes out of sync?), but if the array index
into the ListView->Item array is invalid, it must be. Pretty weird.

Also, if WaitForSIngleObject() fails (to acquire the ListView mutex), popup
an error dialog box. I have not observed any mutex acquisition failures.

---
� Synchronet � Vertrauen � Home of Synchronet � [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/bf431220dd59fefe1c755d9d
Modified Files:
src/sbbs3/ctrl/MainFormUnit.cpp
Log Message:
Use the configured Statistics Interval

for the SBBSCTRL:Statistics windows update timer interval

---
� Synchronet � Vertrauen � Home of Synchronet � [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/ba97cebf8d280eb28d86bbb6
Modified Files:
src/sbbs3/ctrl/MainFormUnit.cpp
Log Message:
Timer interval is in milliseconds, not seconds (whoops)

Also, insure a minimum interval (lower bound) of one second here.

---
� Synchronet � Vertrauen � Home of Synchronet � [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/76d270258fa4bcc644e656a9
Modified Files:
src/sbbs3/ctrl/MainFormUnit.cpp
Log Message:
Use minutes_to_str() for the TimeToday statistics (e.g. "59m", or "5.6h")

---
� Synchronet � Vertrauen � Home of Synchronet � [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/f65fd89a106023a5aa7570ce
Modified Files:
src/sbbs3/ctrl/MainFormUnit.cpp
Log Message:
Resolve crashes during graceful server termination(s)

These crashes have been happening seemingly forever, but only noticed (by me) when running in a debugger, otherwise Windows seems to suppress any exception message/popup since the process terminates anyway.

The problem appears to be that we were setting app controls (e.g. start/stop button states) in the startup->set_state callbacks and it was possible through race conditions that the application (or at least the forms) were actually destroyed already at the time those callbacks are called (to a report server state of STOPPED as one of the last things each server thread does).

The solution was to store the value of the reported server states in (global) variables and asynchronously (at "appy time") update the relevant controls based on the server state(s). Since the LogTimer runs more frequently (2Hz) than UpTimer (1Hz) and isn't stopped (early) during process termination,
that was the place best-suited to do these control updates.

In this process, I also made the app controls make more sense (e.g. the
"Start" button is disabled during server initialization) and the "Abort" dialing while waiting for graceful server termination(s) is much improved
(e.g. lists all the servers still running), but now it does not popup for 60 seconds after termination requested (rather than 30 seconds as before) - as
if the user presses "Yes", this initiates an *ungraceful* exit of the program which could result in crashes (though Microsoft seems to suppress the user notification of these).

---
� Synchronet � Vertrauen � Home of Synchronet � [vert/cvs/bbs].synchro.net